Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the logic for building course details from calendar events to improve code reuse and maintainability. The main change is the extraction of course details aggregation into a new utility function, which is now used in both the calendar component and its associated hook. Additionally, there are minor improvements to how course instructor information is displayed.
Refactoring and code reuse:
buildCourseDetailsinsrc/lib/generator/buildCourseDetails.js, including helper functions for parsing and merging course details.CalendarComponent.jsxanduseCalendarEvents.jsto use the newbuildCourseDetailsfunction instead of duplicating the course details aggregation logic.Minor improvements:
CourseListItemComponent.jsxby using optional chaining and a fallback value.